Fixes issue with top level checks #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2022 08:04
Strum355
reviewed
Apr 29, 2022
server/main/src/main.rs
Outdated
| mod test; | ||
|
|
||
| pub fn is_top_level(path: &Path) -> bool { | ||
| let path = path.as_os_str().to_str().unwrap().replace("\\", "/"); |
Owner
There was a problem hiding this comment.
Can probably replace this with https://docs.rs/path-slash/latest/path_slash/trait.PathExt.html#method.to_slash:
Suggested change
| let path = path.as_os_str().to_str().unwrap().replace("\\", "/"); | |
| use path_slash::PathExt; | |
| let path = path.to_slash().unwrap(); |
Author
|
@Strum355 Implemented the suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only detected top level files are in the world-1, world0 and world1 folders. Mods can add their own worlds, screwing over shader devs like emin